search

weaverba137 / pydl

Library of IDL astronomy routines converted to Python.
BSD 3-Clause "New" or "Revised" License
28 stars 16 forks source link

Python 3 compatibility without 2to3 #4

Closed cdeil closed 10 years ago

cdeil commented 10 years ago

This pull request changes pydl to have a Python 2 and 3 compatible codebase without needing to run 2to3, as recommended in the astropy docs.

There's a lot of lines changed, but most are the simple print "something" to print("something") change.

weaverba137 commented 10 years ago

I can't really do much with this because this is based on the master branch.

cdeil commented 10 years ago

I can't really do much with this because this is based on the master branch.

I don't understand what the problem is. What should I do differently instead?

weaverba137 commented 10 years ago

0.2.3 is the current development branch.

cdeil commented 10 years ago

Wouldn't it make sense to make master the current development branch like Astropy, all affiliated packages, numpy, scipy, .... pretty much every scientific Python package?

Using your own special git workflow makes it extra hard to contribute to pydl, no?

cdeil commented 10 years ago

In any case I'm getting the feeling you maybe don't want this change ... if you do you can easily merge it into the right branch yourself, or let me know and I'll open a pull request against your 0.2.3 branch.

weaverba137 commented 10 years ago

I thought I was following the astropy guidelines. http://docs.astropy.org/en/stable/development/workflow/development_workflow.html#astropy-guidelines-for-git says "Don’t use your master branch for anything."

cdeil commented 10 years ago

@weaverba137 You are misunderstanding the instructions. Astropy and all affiliated packages use the master branch for development.

The instructions you linked to basically say that one should make a feature branch when one wants to contribute ... this is what I did, I made a no_2to3 branch. Now I made a pull request against the master branch of the main pydl repo, which is the usual workflow to contribute.

cdeil commented 10 years ago

If you think the wording of the instructions is not clear, please make a pull request suggesting better explanations.

weaverba137 commented 10 years ago

Keep this open. Let me merge with the 0.2.3 branch first, though. Some of these issues are already fixed in that branch.

weaverba137 commented 10 years ago

You may want to update your checkout of master, then we'll see what remains to be fixed.

cdeil commented 10 years ago

@weaverba137 I've rebased this on master and removed the unnecessary .keys() calls as pointed out by @embray