Unexpected iaxis argument in call to djs_maskinterp()

weaverba137 / pydl

Library of IDL astronomy routines converted to Python.

BSD 3-Clause "New" or "Revised" License

28 stars 16 forks source link

Unexpected iaxis argument in call to djs_maskinterp() #70

Closed tdwelly closed 1 year ago

tdwelly commented 1 year ago

Hi, I noticed a likely typo here: https://github.com/weaverba137/pydl/blob/main/pydl/pydlspec2d/spec2d.py#L439 Within the function filter_thru(), djs_maskinterp() is called with argument 'iaxis', but expects 'axis' instead: https://github.com/weaverba137/pydl/blob/main/pydl/pydlutils/image.py#L63 Simply renaming the argument (iaxis->axis) allows the function to run to completion...but expert eyes are needed to tell if this is the correct behaviour. Many thanks!

weaverba137 commented 1 year ago

That is clearly a bug that may be left over from the original IDL code. I have fixed it in the branch endian-test, if you want to test that yourself. If you find further issues, please report them on #69.

Fixed by d8a5369.