search

weaverba137 / pydl

Library of IDL astronomy routines converted to Python.
BSD 3-Clause "New" or "Revised" License
28 stars 16 forks source link

pydl no longer compatible with astropy 6 #74

Closed havok2063 closed 6 months ago

havok2063 commented 6 months ago

WIth astropy 6.0, they removed the update_default_config method. See https://docs.astropy.org/en/stable/changelog.html#api-changes. Discovered this in my project CI with pydl 0.7.

In the short term, I can pin to astropy < 6. You may want to put in an explicit astropy<6 in your dependencies, or a better long-term solution may be to try to resolve it, so people can still use pydl with astropy > 6.

weaverba137 commented 6 months ago

PyDL v1.0.0 should be released very soon and update_default_config has already been removed from the code.

havok2063 commented 6 months ago

Nice!

weaverba137 commented 6 months ago

@havok2063, The v1.0.0 tag exists, so you could go ahead and test against that, it will probably be another day or so before 1.0.0 appears on PyPI.

weaverba137 commented 6 months ago

@havok2063, version 1.0.0 is on PyPI. It should also be available on conda-forge. I'm going to assume that fixes your issue.

havok2063 commented 6 months ago

Yes this fixes it! Thanks!