weaverba137 / pydl

Library of IDL astronomy routines converted to Python.
BSD 3-Clause "New" or "Revised" License
28 stars 16 forks source link

bspline.__init__() got an unexpected keyword argument 'groupbadpix' #77

Open WenkeRen opened 2 months ago

WenkeRen commented 2 months ago

Hi,

Thanks for your wonderful code. I found an error when I'm trying to run pydlspec2d.spec2d.combine1fiber function. The traceback is as follow:

stack_flux, stack_ivar = spec2d.combine1fiber(loglam_cube, flux_cube, loglam_ref, ivar_cube) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/site-packages/pydl/pydlspec2d/spec2d.py", line 232, in combine1fiber sset, bmask = iterfit(inloglam_r[ss], ^^^^^^^^^^^^^^^^^^^^^^^ File "/site-packages/pydl/pydlutils/bspline.py", line 608, in iterfit sset = bspline(xdata[xsort[maskwork]], **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: bspline.init() got an unexpected keyword argument 'groupbadpix'

To me, it is quite straightforward so I don't provide examples for this error. Probably, due to some update in bspline class, you update the parameter list in the bspline.__init__ but forgot the argument groupbadpix.

Let me know if you need more information about this issue.

Cheers

weaverba137 commented 2 months ago

Thank you @WenkeRen, I don't think groupbadpix was ever implemented, so it's an extraneous argument rather than a missing argument. I will need to investigate further.

WenkeRen commented 2 months ago

True. To make it work in my side, I just commented this parameter out and so far everything works fine for me.