weaverryan / symfony

The Symfony PHP framework
symfony.com
MIT License
2 stars 0 forks source link

Testing first issue #1

Open weaverryan opened 9 years ago

weaverryan commented 9 years ago

zzz

weaverryan commented 9 years ago

I'm commenting! Had to change my comment

weaverryan commented 9 years ago

This one has multiple lines

echo 'foo';

Done!

weaverryan commented 9 years ago

This issue needs work

weaverryan commented 9 years ago

I'm going to update this: Status: needs work

weaverryan commented 9 years ago

Ahem, I said: Status: needs work

weaverryan commented 9 years ago

Well, now I think it's ok:

Status: Reviewed

weaverryan commented 9 years ago

Actually, Status: works for me

webmozart commented 9 years ago

Status: Needs Review

webmozart commented 9 years ago

Status: Needs Review

webmozart commented 9 years ago

Awesome :)

weaverryan commented 9 years ago

I think you're wrong Bernhard :p

Status: Needs work

stof commented 9 years ago

status: reviewed by me

stof commented 9 years ago

trying without the extra text maybe ? status: reviewed

weaverryan commented 9 years ago

@stof we just changed it to need to be on its own line by itself to prevent cases like these: https://github.com/weaverryan/carson-issue-butler/pull/3/files#diff-3f19187731b04a6be9f94865aeedbd24R119

But as a human, I would have wanted your original thing to work. So if we start using this, we'll see what people trip over and maybe add some more cases

webmozart commented 9 years ago

I agree, real life testing will tell us more :)

weaverryan commented 9 years ago

Status: Needs review