weaversa / MPHF

An efficient minimal perfect hash function generator for small sets
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Tighter bind to SAT solvers #1

Open weaversa opened 4 years ago

weaversa commented 4 years ago

tmpnam is not ideal for a number of reasons - the most prominent here being the lack of stability in a threaded environment. It would be nice to replace tmpnam with something like this:

https://stackoverflow.com/questions/6171552/popen-simultaneous-read-and-write

Or, just pick one or more top solvers written in C/C++ and integrate them tightly.

socketpair commented 1 year ago

GCC: the use oftmpnam' is dangerous, better use mkstemp'

I suggest https://en.cppreference.com/w/c/io/tmpfile

weaversa commented 1 year ago

We'd be happy to accept a pull request :-)