search

weaveworks-experiments / compare-revisions

Experimental thing for comparing what's on k8s clusters
Apache License 2.0
0 stars 0 forks source link

compare-revisions sometimes does not list changes for cortex services #21

Closed leth closed 6 years ago

leth commented 7 years ago

If one service has been updated, the others sometimes stop showing changes

rade commented 7 years ago

I thought the particular incident that prompted the filing of this issue pertained to scope.

leth commented 7 years ago

Ah, I think perhaps I made a mistake with both? I'm not sure

jml commented 7 years ago

I think this is just a bug in the config file, in that it's too restrictive about what directories belong to which services.

Easy fix is to get rid of the directories. Hard-core fix is to use Bazel dep information to reverse the dependency graph from the built image and use that as filter.

jml commented 6 years ago

Don't think this is a bug in compare-revisions per se. There's an implicit feature request to do proper commit tracking, but that's out of scope for this project.