Move ValidConfig to Config module - Githubissues

weaveworks-experiments / compare-revisions

Experimental thing for comparing what's on k8s clusters

Apache License 2.0

0 stars 0 forks source link

Move ValidConfig to Config module #30

Closed jml closed 6 years ago

jml commented 6 years ago

I don't really understand why the ValidConfig data type was in Engine, rather than Config.

As mentioned in the documentation, we have three config structures:

the flags (AppConfig)
the schema for the file (Config)
a post-processed schema that's guaranteed to make sense (ValidConfig)

I think putting them all in the one file makes that hierarchy more clear.

Depends on #29