search

weaveworks-experiments / compare-revisions

Experimental thing for comparing what's on k8s clusters
Apache License 2.0
0 stars 0 forks source link

Bootstrapify pages #41

Closed jml closed 6 years ago

jml commented 6 years ago

Makes the pages much prettier. I haven't done anything with layout, but I'm happy to take concrete suggestions.

Haven't tested the Docker image, due to not being on Linux, and forgetting the Stack command to build from within Docker.

awh commented 6 years ago

Needs screenshot

jml commented 6 years ago
screen shot 2018-06-25 at 15 58 22

Note I haven't changed the HTML in any way. Suggestions welcome.

jml commented 6 years ago

You asked for jumbotron.

Home page

screen shot 2018-07-02 at 12 17 06

Images

screen shot 2018-07-02 at 12 17 12

Revisions

screen shot 2018-07-02 at 12 16 56

Changelog

screen shot 2018-07-02 at 12 17 21

I hope you're happy.

I've changed the lucid import to be import Lucid, bringing all the symbols into the API module's namespace. While I don't like this practice in general, I think it makes the HTML templates easier on the eye.

jml commented 6 years ago

A few places mention things can be improved with servant 0.14 - any reason why not to use it now?

I was already concerned with the amount of time I'd spent on the PR, and the cost of review. Also, when I wrote the comments, servant 0.14 was not released. I'll happily do a follow-up PR that switches to 0.14.