Discovery should monitor the Weave container

weaveworks-experiments / discovery

Weave Net peer discovery

15 stars 8 forks source link

Discovery should monitor the Weave container #2

Open inercia opened 9 years ago

inercia commented 9 years ago

When using the local Weave router, Discovery should listen for events on the weave container. If the container disappears, it should remove the router's IP from the discovery backend.

inercia commented 9 years ago

We could implement this in two different ways:

listening for Docker events (this would probably require some privileges)
we must periodically refresh the registration in the backend, so we could do a GET /status from the router we are advertising before the refresh. Tthis would also work for remote routers...

Any sugestion on how to tackle this @rade?

What should we do if the router is dead? Discovery should probably exit...

rade commented 9 years ago

Any sugestion on how to tackle this

Depends on how promptly you want the removal to happen. With events it will happen very quickly. But if you don't care then a 'healthcheck' is fine and, as you say, is more flexible.