search

weaveworks-experiments / kspan

Turning Kubernetes Events into spans
Apache License 2.0
792 stars 56 forks source link

Pass eventTime to createTraceFromTopLevelObject #10

Closed vrutkovs closed 3 years ago

vrutkovs commented 3 years ago

Spec update time may be unset, so span time should be set to event time

bboreham commented 3 years ago

Great stuff, thanks, but some merge conflicts after the update of OpenTelemetry which renamed a bunch of things. If you can rebase please do, otherwise I'll try to fix it in a merge commit.

vrutkovs commented 3 years ago

Rebased