Closed vrutkovs closed 3 years ago
Marking as WIP as it fails existing tests
Interesting thought, thanks. It is a bit of a problem dealing with a "big bag of heuristics" that you tweak one thing and another thing breaks.
Do you think you could add a test (source events and expected output) for the new behaviour you are adding?
Do you think you could add a test (source events and expected output) for the new behaviour you are adding?
yup, will do
@vrutkovs is this PR still active?
Sorry, this needed quite a few changes in events we emit, so I dropped this.
Feel free to pick up of course
If no actor can be found for the event, set it to object itself. This would ensure events created by operators (i.e. new pods) can be traced properly. In order to structure this correctly actor == object in objRef and this case takes precendence over ownership check.
This also updates
createTraceFromTopLevelObject
:status
update time instead ofspec
, so that pod started event would be have valid timestamps.component
so that it could be set from event source instead of managedFields.Not entirely sure how to reproduce this - in Openshift this can be reproduced by using
oc debug node/
which creates a priviledged pod on the node. I think anykubectl create pod
would replicate this behaviour.Before:
After: