Setting error status is broken

weaveworks-experiments / kspan

Turning Kubernetes Events into spans

Apache License 2.0

785 stars 56 forks source link

Setting error status is broken #15

Closed bboreham closed 3 years ago

bboreham commented 3 years ago

The feature added in #8 no longer works for me, so somewhere in the intervening code it got broken.

Here's an example: the same pod is pulling a nonexistent image reference, first with code from abb0929f360a51d1f9551d17485e03d982c1efd5 and then from bd42709ce88c438e57946d5f76911a092e265e1f (current main)

bboreham commented 3 years ago

Looks like this was caused by an incompatibility between the newer OpenTelemetry libraries and the version of Jaeger I was running. Updating to the latest (4 weeks ago as of now; image ID 66845d9ac52b) cured the problem.