search

weaveworks-experiments / kspan

Turning Kubernetes Events into spans
Apache License 2.0
785 stars 56 forks source link

incompatibility with AWS XRay (via OpenTelemetry collector) #43

Open errordeveloper opened 2 years ago

errordeveloper commented 2 years ago

I just thought it might be useful for folks to be know that the kspan trace IDs are currently not compatible with AWS XRay: https://github.com/open-telemetry/opentelemetry-collector-contrib/discussions/5257#discussioncomment-1343360

bboreham commented 2 years ago

Thanks for the report. Shouldn’t that be filed as an XRay incompatibility with OpenTelemetry?

bboreham commented 2 years ago

It is feasible to change the scheme kspan uses, at the cost of losing trace continuity across a restart of kspan. Or add some persistence mechanism to cover the restart.

errordeveloper commented 2 years ago

Thanks for the report. Shouldn’t that be filed as an XRay incompatibility with OpenTelemetry?

I updated the title.

errordeveloper commented 2 years ago

It is feasible to change the scheme kspan uses, at the cost of losing trace continuity across a restart of kspan. Or add some persistence mechanism to cover the restart.

Yes, it's neat to have restart persistence by the virtue of consistent hashing. Maybe someone could think of this as a separate mode. By the way, very similar use timestamps seems to be mandated by the W3C spec also...