search

weaveworks-experiments / kspan

Turning Kubernetes Events into spans
Apache License 2.0
788 stars 56 forks source link

improve: adjust parent span's startTime when child span's startTime e… #53

Open cindyliu-tec opened 2 years ago

cindyliu-tec commented 2 years ago

adjust parent span's startTime when child span's startTime early than it's parent span

bboreham commented 1 year ago

Thanks for the PR. Could you share a little how this situation comes up, why you care about it, etc.?

cindyliu-tec commented 1 year ago

Thanks for the PR. Could you share a little how this situation comes up, why you care about it, etc.?

I want it seem more like a normal request trace, a father span end when it's last child span end. if there still have child span being processing, but upper level span already ended, I think it looks weird. for example, when deployment-controller receive a mission to deploy a workload, people instinctively fell the mission only end when the workload is deployed successful or failed, instead of just assign tasks to replicaset-controller then itself end.