search

weaveworks-experiments / kspan

Turning Kubernetes Events into spans
Apache License 2.0
785 stars 56 forks source link

kspan emits events in UTC #6

Open felipecruz91 opened 3 years ago

felipecruz91 commented 3 years ago

Hi,

kspan emits events in UTC, e.g:

{"ref": "replicaset:default/nginx-6799fc88d8", "name": "Deployment.ScalingReplicaSet", "start": "15:27:24.000", "end": "15:27:24.000"}

This causes traces not being shown unless the Loopback dropdown is set to "Last 2 Hours".

bboreham commented 3 years ago

Hi, I was hesitant to comment here because my own timezone was UTC, but since Sunday we've been in BST and I haven't noticed any problem viewing spans. They are emitted on my Kubernetes cluster in UTC and displayed in Jaeger in my local timezone.

I believe that emitting timestamps in UTC is correct; this is the one thing guaranteed to be consistent for all actors. Rendering the time in local timezone is a job for the final UI.

Maybe something is interfering with Jaeger understanding your local timezone?