weaveworks-guides / weave-net-legacy

Weave Net Old Guides

Apache License 2.0

88 stars 33 forks source link

Update Docker Machine guide #186

Closed errordeveloper closed 8 years ago

errordeveloper commented 8 years ago

This is basic update to this popular guide, to make sure most visible issue are fixed (like #178).

Please don't get too picky on the details, I think we can get this improved a lot more in many ways, as Docker for Mac and Windows become more stable. Also, the new Swarm features would affect a lot of what's shown here anyway.

@abuehrle please merge and publish ASAP.

rade commented 8 years ago

why do we have a copy of the weave script!?!?

Rest LGTM.

errordeveloper commented 8 years ago

why do we have a copy of the weave script!?!?

That's been discussed over and over, original motivation was to have one less thing for the user to download and check version etc. We have since identified a number of other issue with this approach, and last time @abuehrle was going to make this change, but for some reason the script is still in master. For the purpose of this PR, I've just updated what's there.

rade commented 8 years ago

That's been discussed over and over

88 and #183.

Anyway, as I said, LGTM.