Open richardcase opened 2 years ago
This issue is stale because it has been open 60 days with no activity.
This issue is stale because it has been open 60 days with no activity.
@richardcase After going through what the delete plan looks like atm and the proposal in this issue, I think we should
runtime.deleteDirectory
and shift its logic to fcProvider.Delete()
.fcProvider.Delete()
to fcProvider.Stop()
.Then update the deletion plan to replace
fcProvider.Delete()
with a step which uses fcProvider.Stop()
runtime.deleteDirectory
with a step uses fcProvider.Delete()
This issue is stale because it has been open 60 days with no activity.
Describe the solution you'd like: With #329 we removed
Stop
from the Microvm provider interface and form the firecracker implementation as stop isn't used (we currently take action in delete).We should add
Stop
back in and update flintlock so that the following happens:Stop
stops the microvm from running (i.e. stops firecracker procvess)Delete
deletes any files/resources that where created my the provider implementation. So for Firecracker it will be things like firecracker.cfg & metdata.jsonWhy do you want this feature:
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]