weaveworks-liquidmetal / flintlock

Lock, Stock, and Two Smoking MicroVMs. Create and manage the lifecycle of MicroVMs backed by containerd.
https://weaveworks-liquidmetal.github.io/flintlock/
Mozilla Public License 2.0
455 stars 29 forks source link

Re-add `Stop` to provider interface and differentiate stop & delete #330

Open richardcase opened 2 years ago

richardcase commented 2 years ago

Describe the solution you'd like: With #329 we removed Stop from the Microvm provider interface and form the firecracker implementation as stop isn't used (we currently take action in delete).

We should add Stop back in and update flintlock so that the following happens:

Why do you want this feature:

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

aryan9600 commented 1 year ago

@richardcase After going through what the delete plan looks like atm and the proposal in this issue, I think we should

Then update the deletion plan to replace

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 60 days with no activity.