search

weaveworks / build-tools

Collection of build & test tools shared by various Weaveworks projects
Other
44 stars 20 forks source link

Terraform 0.12.0 lint #177

Open morancj opened 3 years ago

morancj commented 3 years ago

Updates for https://github.com/weaveworks/build-tools/pull/176 via https://github.com/weaveworks/weave/issues/3913 and https://github.com/weaveworks/weave/pull/3914

morancj commented 3 years ago

https://github.com/FiloSottile/gvt is archived: if someone more familiar with Go than I would kindly TAL, hopefully we can get these tests passing. It seems this repo is used in a lot of places! :slightly_smiling_face:

kingdonb commented 3 years ago

9cc4ff7

In this commit I added a go.mod file, I think this means the go get statements in build/golang/Dockerfile are redundant now. I have not transitioned apps myself from gopath to go mod before, I don't know if it makes sense to merge this as-is just because the tests are passing.

I think we need someone to take a quick look who knows about go mod migration (but at least I got the build working again)

kingdonb commented 3 years ago

Thanks. If someone who knows anything about the release cycle of this package is comfortable merging this, I definitely won't stop you.

The build is green at least, if there are issues to follow up they can be handled in a separate PR. @morancj Back in your court?