Open roidelapluie opened 3 years ago
https://github.com/weaveworks/common/blob/47e357f4e1badb7da17ad74bae63e228bdd76e8f/tracing/tracing.go#L38
Jaeger is always enabled because LocalAgentHostPort is by default ('localhost:6831').
Annoyingly the env variables used by jaeger are not publicly exposed by the jaeger package so a quick&clean fix is not that easy.
https://github.com/jaegertracing/jaeger-client-go/blob/17fd3e8e517a4630dc276675cb2987782094a022/config/config_env.go#L201-L207
https://github.com/weaveworks/common/blob/47e357f4e1badb7da17ad74bae63e228bdd76e8f/tracing/tracing.go#L38
Jaeger is always enabled because LocalAgentHostPort is by default ('localhost:6831').
Annoyingly the env variables used by jaeger are not publicly exposed by the jaeger package so a quick&clean fix is not that easy.