search

weaveworks / common

Libraries used in multiple Weave projects
Other
129 stars 92 forks source link

Fix master build #229

Closed rfratto closed 3 years ago

rfratto commented 3 years ago

The master build was broken and tests wouldn't run locally.

cc @bboreham

bboreham commented 3 years ago

Was this missed from #226 ?

rfratto commented 3 years ago

I don't think so: the test that still used the old package was added in #227. Prior to that everything was using the new logging package.

bboreham commented 3 years ago

OK possibly overlapping changes. Thanks!