search

weaveworks / common

Libraries used in multiple Weave projects
Other
129 stars 92 forks source link

Removed debug log on successfuly gRPC requests from GRPCServerLog #241

Closed pracucci closed 2 years ago

pracucci commented 2 years ago

Yesterday I was looking at memory allocations (bytes & objects) in Mimir ingesters with an high volume of small requests, and I've noticed memory allocations triggered by GRPCServerLog are non negligible. In this scenario, logging a successful request with debug level (which is then discarded by the filter because we configure logger min level = info) results in about 4% memory allocations:

Screenshot 2022-05-20 at 10 39 17

What's the sentiment if we remove the debug log on successful gRPC requests at all?

pracucci commented 2 years ago

Will be superseeded by https://github.com/weaveworks/common/pull/244.