weaveworks / common

Libraries used in multiple Weave projects
Other
129 stars 92 forks source link

Reproducable httpgrpc.pb.go build #264

Closed krajorama closed 1 year ago

krajorama commented 1 year ago

Reproducable httpgrpc.pb.go build

Use gogo protobuf options explicitly to generate the same Equal, String, GoString etc functions in the protobuf implementation.

Add tools.go to download the gogo.proto dependency. Add vendor directory as include for protoc to load the dependency. Update protoc version otherwise there is a diff in the generated files, most notably const = proto.GoGoProtoPackageIsVersion3 is replaced with const = proto.GoGoProtoPackageIsVersion2

Add check-protos target

This is a simple check to catch if proto generation changes files.

Check generated protobuf files in CI

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com