search

weaveworks / eks-quickstart-app-dev

Example flux manifests for eksctl gitops
Other
56 stars 43 forks source link

add .wksctlignore file #32

Closed chanwit closed 4 years ago

chanwit commented 4 years ago

add a blank .wksctlignore file to tell wksctl that it must ignores files from this directory when doing wksctl profile enable.

chanwit commented 4 years ago

kindly ping @stefanprodan @palemtnrider @mflendrich is it ok to implement this idea?

palemtnrider commented 4 years ago

Hi @chanwit I don't see where weaveworks/wksctl might be checking for this file. Is that going to be added later?

chanwit commented 4 years ago

@palemtnrider I'm working on it. Feedback from @stefanprodan that I should use something similar to .gitignore.

chanwit commented 4 years ago

Here's the implementation to recognize .wksctlignore in wksctl profile enable.

https://github.com/weaveworks/wksctl/pull/104

martina-if commented 4 years ago

@chanwit Sorry for the very late reply, we haven't been watching this repo.

I think this repo doesn't know anything about wksctl so it doesn't make sense to add a file here for that. Instead that file should be created by wks or other tooling that may connect them.