search

weaveworks / gitopssets-controller

Manages the GitOpsSet CRDs.
Apache License 2.0
9 stars 5 forks source link

Directory generator #34

Closed bigkevmcd closed 1 year ago

bigkevmcd commented 1 year ago

This generates from a GitRepository but parsing directories from it.

bigkevmcd commented 1 year ago

I wonder if we can come up with guidelines on the naming of elements.

For combination in Matrixes, we kinda want them to be "unique"?

Theres an argument tho', that the Matrix could combine them by prefixing the elements...

So, List combined with GitRepository would get... List.env and GitRepository.Base for example

foot commented 1 year ago

So, List combined with GitRepository would get... List.env and GitRepository.Base for example

Agree, might be handy.. matrix of 2 lists? We could allow an optional name?

foot commented 1 year ago

Yeah, it makes sense!

Its a bit confusing that sometimes w/ the git gen gives you filecontents and other times filepaths. But I think thats a familiarity thing. Argo seems to do this too.

bigkevmcd commented 1 year ago

It turns out to be really useful tho'!

Scanning a directory to find all sub-dirs, to be inserted into a Kustomization for example, you wouldn't want to read all the files in all the dirs, because you'd be throwing that out?