weaveworks / gitopssets-controller

Manages the GitOpsSet CRDs.
Apache License 2.0
9 stars 5 forks source link

Provide an optional name field in the generator #72

Closed souleb closed 1 year ago

souleb commented 1 year ago

It would be useful to able to address the image generator latestImage with an optional name field. We could then have several generator of the same type in a matrix.

souleb commented 1 year ago

cc @bigkevmcd

foot commented 1 year ago

Could you share your specific use case @souleb? Maybe we could include it in the docs

foot commented 1 year ago

Is the matrix a good fit here?

If you

generators:
    - matrix:
        generators:
          - imagePolicy:
            policyRef: podinfo
            name: podinfo
          - imagePolicy:
            policyRef: cert-manager
            name: certManager

You might end up 4 generated items? 🤔

foot commented 1 year ago

You might end up 4 generated items? 🤔

Chatted w/ kevin, this is not how this works ofc.

1 x 1 = 1, this above would only generate a single repetition of the templates.

souleb commented 1 year ago

in my case the template will be a flux kustomization that will reconcile several deployments. I want to be able to have as many imagePolicyGenerator as deployments.

souleb commented 1 year ago

Yes a single kustomization template to reconcile several deployments.

bigkevmcd commented 1 year ago

https://github.com/weaveworks/gitopssets-controller/pull/76