Missing validation functions

weaveworks / ignite

Ignite a Firecracker microVM

https://ignite.readthedocs.org

Apache License 2.0

3.49k stars 226 forks source link

Missing validation functions #301

Open twelho opened 5 years ago

twelho commented 5 years ago

All missing validation functions are tracked here. If you find some validation missing, add it to this list or comment on this issue.

[ ] VM CPUs
[ ] VM memory
[ ] VM disk max/min sizes
[ ] VM port mappings

luxas commented 5 years ago

Adding that network mode CNI and VM portmappings are mutually exclusive.

twelho commented 5 years ago

CNI now supports port mappings, so removing the mutual exclusitivity requirement.

anirudh-goyal commented 4 years ago

Hello, I am a student from the University of Texas at Austin. I wanted to know if a group of my colleagues and I could work on this issue as part of an assignment for our virtualization class. Thank you!

(We don't have experience with virtualization so we chose an issue with the label good first issue)

stealthybox commented 4 years ago

Hi @anirudh-goyal, we would welcome your contributions

This is definitely an approachable issue. It's related to the api's we use to describe VM's

The code that needs to change starts here: https://github.com/weaveworks/ignite/blob/9c9c4db/pkg/apis/ignite/validation/validation.go#L21-L22

Also, feel free to join our development calls on Monday.

jeffreyxie0615 commented 1 year ago

Hi! Is this issue still open to be worked on? My partner and I are students from UT Austin, and we were wondering if we could tackle this as a good first issue for our virtualization class?