search

weaveworks / ignite

Ignite a Firecracker microVM
https://ignite.readthedocs.org
Apache License 2.0
3.49k stars 228 forks source link

Ignited gitops fails to handle new vm added to GitHub #484

Open palemtnrider opened 5 years ago

palemtnrider commented 5 years ago

I'm running ignited gitops git@github.com:myorg/myrepo.git and when I add a new VM definition to the repo, the ignited gitops process fails with

INFO[0505] New commit observed on branch "master": d0179696fe70471b97a9fef0205f17acde51037e. User initiated: true FATA[0505] The GitOps commit loop terminated with an error git commit and/or push error: no changes made in repo

ignited gitops needs to correctly handle changes to the repo contents.

My guess is that ignited updated the repo with status information and can't handle when the repo contents change after it writes status. However, it's possible this is operator error.

Ignite version: version.Info{Major:"0", Minor:"6+", GitVersion:"v0.6.0-106+0a90cfbced8163-dirty", GitCommit:"0a90cfbced8163507831f885d3eef343e20f0875", GitTreeState:"dirty", BuildDate:"2019-11-04T04:05:01Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"} Firecracker version: v0.18.0 Runtime: containerd

chanwit commented 5 years ago

Thank you @palemtnrider I'm looking at it

chanwit commented 5 years ago

@palemtnrider we need to look at gitops-toolkit repo to fix this issue.

kosmonavtika commented 4 years ago

Is this still an issue? Seems to be a quite breaking bug.