Upgrade firecracker to v0.22.4

weaveworks / ignite

Ignite a Firecracker microVM

https://ignite.readthedocs.org

Apache License 2.0

3.49k stars 226 forks source link

Upgrade firecracker to v0.22.4 #797

Closed gaby closed 3 years ago

gaby commented 3 years ago

This PR takes care of upgrading firecracker from v0.22.1 to v0.22.4

Review of firecracker changes:

v0.22.2

Fixed inconsistency in YAML file InstanceInfo definition

v0.22.3

Fixed off-by-one error in virtio-block descriptor address validation.

v0.22.4

Fixed the reported used bytes for any virtio-block request.
Fixed all virtio-block read/write operations to valid guest addresses with buffer length of 0 to result in no-op.

darkowlzz commented 3 years ago

Thanks for updating the firecracker version. The changes look good to me. Can you also update the installation docs to reflect this change? https://github.com/weaveworks/ignite/blob/master/docs/installation.md#ignite-cli - firecracker version in the output. Also, maybe squash the commits if possible :slightly_smiling_face:

gaby commented 3 years ago

@darkowlzz Done, I'm using Github Desktop app and it doesn't have an option for squashing commits. I know there's an option to do it here via the PR but i don't see it on this repo.

darkowlzz commented 3 years ago

@darkowlzz Done, I'm using Github Desktop app and it doesn't have an option for squashing commits. I know there's an option to do it here via the PR but i don't see it on this repo.

That's okay. np.

stealthybox commented 3 years ago

Thank you for all of this incredible work. This is significant maintenance effort to track all the dependencies -- we really appreciate it.