search

weaveworks / ignite

Ignite a Firecracker microVM
https://ignite.readthedocs.org
Apache License 2.0
3.49k stars 224 forks source link

Change dhcp.hostname value #851

Closed networkop closed 3 years ago

networkop commented 3 years ago

At the moment VM's hostnames are set to the value of their UUID which is not human-readable.

// Set the VM hostname to the VM ID
dhcpIface.Hostname = vm.GetUID().String()

How about we change this to vm.Name instead to make things more human-friendly?

darkowlzz commented 3 years ago

I believe this behavior is based on docker's behavior

$ docker run --rm -ti ubuntu bash
root@9a98cec1e940:/#
networkop commented 3 years ago

ok, makes sense