search

weaveworks / ignite

Ignite a Firecracker microVM
https://ignite.readthedocs.org
Apache License 2.0
3.49k stars 226 forks source link

update cni version to 1.0.1 #903

Open abn opened 2 years ago

abn commented 2 years ago

This builds on top of the work done by @gaby in #863.

Closes: #863

gaby commented 2 years ago

👍🏻 For this, I couldnt get my builds pass for #863

abn commented 2 years ago

@gaby think I got the builds to pass now. I am not sure how to debug the e2e tests as I do not really use ignite. I came here trying to update cni version for containerlabs. Any help would be appreciated.

Also I am unsure what snyk is complaining about as I cannot access the details.

gaby commented 2 years ago

@chanwit @darkowlzz @stealthybox any updates on this?

darkowlzz commented 2 years ago

Hi @abn and @gaby , sorry for the late response. Before we update CNI, we'll have to bring back ignite to a good shape. I've created https://github.com/weaveworks/ignite/pull/923 to fix the current CI failures. I also see a lot of dependency updates in this PR that may not be directly related to CNI. I can try updating those dependencies in a separate PR once the builds are in a good shape. Just trying to reduce the change surface to avoid any unintended changes.

Thanks for pushing this forward.

darkowlzz commented 2 years ago

Hi, I tried updating the unrelated dependencies first and when I updated containerd, it also updates CNI to v1, which also required updating firacracker-go-sdk, as the old version no longer worked with new CNI, and everything else. So at the end, I ended up with everything that's in this PR. The main branch is in a good state now with all the pipelines passing. It'd be good if you just rebase this and see how the pipeline behaves.

I'd like to know the reason for changing run to create in e2e test e2e/config_test.go in the last commit. I believe we need it to be run for the runtime to be set on the VMs. Create just creates the object on disk. Since the CI is green now, maybe you can try to see what happens without those change?