search

weaveworks / ignite

Ignite a Firecracker microVM
https://ignite.readthedocs.org
Apache License 2.0
3.49k stars 223 forks source link

e2e: Set containerd socket address in RMI command #924

Closed darkowlzz closed 2 years ago

darkowlzz commented 2 years ago

In machines where continerd socket isn't in /run/containerd/containerd.sock, the default path, the tests fail to cleanup the downloaded images in registry auth tests, resulting in unexpected test failures due to old images.

Export StatContainerdSocket() from pkg/runtime/containerd/ and use it in the e2e test to determine the containerd socket.

The test failures are unrelated and are fixed by https://github.com/weaveworks/ignite/pull/923 .

stealthybox commented 2 years ago

Ooh nice catch. That function makes sense to export, and I'm glad it's already factored nicely, where it doesn't require any changes to do so.