weaveworks / ignite

Ignite a Firecracker microVM
https://ignite.readthedocs.org
Apache License 2.0
3.49k stars 223 forks source link

add parameter judgment for "--cpus num" #936

Closed slark-yuxj closed 1 year ago

slark-yuxj commented 2 years ago

add parameter judgment for "--cpus num". When num does not meet the conditions (1 or even numbers between 1 and 32), you need to report an error and do not create a virtual machine

stealthybox commented 1 year ago

Thanks for the patch!

Curious, where did you get a max count of 32 from? I know there is hardware that has many more cores than that.