Move all GenericCheckErr calls from to PersistentPreRun stage of cobra. A couple of them are already there to begin with (this specially helps ignited command as Preload checks for MANIFEST_DIR and fails).
Remove TODO statement on isNonRootCommand() function (we already handle each subcommands).
Fix typo??? in populating ignited provider (it was ignite).
This is pretty much a copy and paste of https://github.com/weaveworks/ignite/pull/676 but for
ignitedcommand.I also did some minor extra things:
GenericCheckErrcalls from to PersistentPreRun stage of cobra. A couple of them are already there to begin with (this specially helpsignitedcommand as Preload checks forMANIFEST_DIRand fails).isNonRootCommand()function (we already handle each subcommands).ignitedprovider (it wasignite).