weaveworks / integrations

Weave Third-Party Integrations
Apache License 2.0
26 stars 22 forks source link

Cloud formation: the WeaveScope output shouldn't be loadbalanced #115

Closed 2opremio closed 4 years ago

2opremio commented 7 years ago

The WeaveScope output goes through an ELB:

screen shot 2016-11-17 at 12 42 47

This is wrong since it leads to a split brain in the apps, affecting things like terminal spawning:

See: https://github.com/weaveworks/scope/issues/2016#issuecomment-261226026

errordeveloper commented 7 years ago

Perhaps we could just run one app behind the ELB?

2opremio commented 7 years ago

Why use an ELB if there's going to be a single app? I would suggest simply enabling public DNS for the instances and picking one of them for the WeaveScope output.

errordeveloper commented 7 years ago

Why use an ELB if there's going to be a single app?

Good question! The reason for this is that there is no other easy way to display a URL in outputs section of CloudFormation stack status page.

2opremio commented 7 years ago

Then fine as long as it works and it's commented (assuming you can comment in CF templates)

errordeveloper commented 7 years ago

assuming you can comment in CF templates

No, it's JSON.

lukemarsden commented 7 years ago

Can we just tell people to use Weave Cloud for their Scope UI?

errordeveloper commented 7 years ago

Luke, yes, I've asked the same question earlier. Fons believes that the extra step needed right now doesn't do well for UX, but we can do that once we have new getting started page, we can just link to CloudFormation with a toke in the URL.

On Mon, 21 Nov 2016 at 15:54 lukemarsden notifications@github.com wrote:

Can we just tell people to use Weave Cloud for their Scope UI?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/weaveworks/integrations/issues/115#issuecomment-261977838, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPWS-r9dwMp0M-q2EmB7Dh3RY56ct9Wks5rAb7EgaJpZM4K1NYi .

errordeveloper commented 7 years ago

I would prefer to fix this with sticky sessions. Fons, you have mentioned that you foresee some problems with that - could you please outline those?

On Mon, 21 Nov 2016, 16:05 Ilya Dmitrichenko, errordeveloper@gmail.com wrote:

Luke, yes, I've asked the same question earlier. Fons believes that the extra step needed right now doesn't do well for UX, but we can do that once we have new getting started page, we can just link to CloudFormation with a toke in the URL.

On Mon, 21 Nov 2016 at 15:54 lukemarsden notifications@github.com wrote:

Can we just tell people to use Weave Cloud for their Scope UI?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/weaveworks/integrations/issues/115#issuecomment-261977838, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPWS-r9dwMp0M-q2EmB7Dh3RY56ct9Wks5rAb7EgaJpZM4K1NYi .

2opremio commented 7 years ago

you foresee some problems with that - could you please outline those?

The stateful nature of sticky sessions brings problems in my experience. But, give it a spin and let's see what happens.

errordeveloper commented 7 years ago

Turns out classic ELB only supports stick session for HTTP listeners, and Scope listener has to be a TCP one, due to the use of WebSockets. I haven't looked into ELBv2 yet, and I'd rather encourage the use Weave Cloud, which is also more secure as standalone mode doesn't even do TLS.