Prevent self-update for debugging

weaveworks / launcher

Weave Cloud Launcher

Apache License 2.0

10 stars 13 forks source link

Prevent self-update for debugging #107

Closed errordeveloper closed 4 years ago

errordeveloper commented 6 years ago

Right now, if I need tweak the agent config for debugging, any of my tweaks are dropped right away, as self-update kicks in. Setting the poll URL to empty string resulted in agent getting stuck. Trying to set URL to be a gist with my tweaked config was trickier the I expected.

errordeveloper commented 6 years ago

Well, integration_install_update_flow fails, and that may seem kind of unsurprsing, but I'm not sure how to go about making it work with this change.

errordeveloper commented 6 years ago

Is this test setting newLabel in the file on the server and expects it to get pulled down immediately, or what is happening exactly? In any case, this change shouldn't affect the behaviour unless AgentPollURL is empty or otherwise invalid...

dlespiau commented 6 years ago

In the update integration test:

• Check the agent updated correctly
Failed to self update. Label newLabel=foo does not exist.
Exited with code 1

edit: oh, you already noted that.

errordeveloper commented 6 years ago

I think the test failure was a flake. Now we have an issue with cyclomatic complexity of 22...

errordeveloper commented 4 years ago

Closing in favour of #304!