search

weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

Log the reason why the auto-update failed, not that it was successfully rolled back #108

Open dlespiau opened 6 years ago

dlespiau commented 6 years ago

When agent fails to auto-update we have:

*errors.errorString: Rollback success
  File "/go/src/github.com/weaveworks/launcher/vendor/github.com/getsentry/raven-go/client.go", line 719, in CaptureErrorAndWait
  File "/go/src/github.com/weaveworks/launcher/agent/main.go", line 71, in logError
  File "/go/src/github.com/weaveworks/launcher/agent/main.go", line 125, in selfUpdate
  File "/go/src/github.com/weaveworks/launcher/agent/main.go", line 131, in updateAgents
  File "/go/src/github.com/weaveworks/launcher/agent/main.go", line 241, in func1
  File "/go/src/github.com/weaveworks/launcher/vendor/github.com/oklog/run/group.go", line 38, in func1

We should log why the auto-update fails instead.