search

weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

custom agent configuration #145

Open leth opened 6 years ago

leth commented 6 years ago

You can configure flux, but all other changes to agent configs will be overwritten

Closely related to https://github.com/weaveworks/launcher/issues/78

rade commented 6 years ago

From @bricef in #244 ...

This doesn't need to be published to customers, but most serious users will need some way to (in priorities of requests):

  1. Configure the prometheus agents from "Scrape everything" to "Scrap what I tell you to".
  2. Disable scope write access
  3. Disable scope altogether

@dlespiau suggested a CRD with a flag map, so that launcher would react to changes to that CRD and I think that would work perfectly.

leth commented 6 years ago

I'm all for having some means to configure this kind of thing. I just wonder how we'd make a nice user-interface for this.

CRDs may be gitops friendly, but they take a bit more work to make user-friendly. We can't simply say "go via flux", as if a user is does not have flux configured with a repo it'd be in read-only mode.

Anyhow, just thinking 'aloud' please don't let this stop us from implementing something!

bricef commented 6 years ago

Most SaaS customers don't need to worry about this, but most of the ones we deal with directly do. Even if this isn't exposed directly to customers, I'd like to be able to tell them "Run this command to make your problem go away" rather than have to jump through the hoops we have now.

rade commented 6 years ago

I am surprised that no flux items appeared on your list, e.g. configuring known_hosts and other credentials stuff in order to get access to private git repos.

bricef commented 6 years ago

@rade - That's captured in other issues. Although that would be a perfect place to put custom git repo and image registry info.