weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

Fix --output usage #161

Closed dlespiau closed 6 years ago

dlespiau commented 6 years ago

Fixes: #159

dlespiau commented 6 years ago

Note: The lint check is still pending as this PR renames lint to global_tests, everything passes though.

dlespiau commented 6 years ago

I've also tested things on a 1.6 cluster (minikube 0.20.0) and a 1.6 kubectl:

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.13", GitCommit:"14ea65f53cdae4a5657cf38cfc8d7349b75b5512", GitTreeState:"clean", BuildDate:"2017-11-22T20:29:21Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.4", GitCommit:"d6f433224538d4f9ca2f7ae19b252e6fcb66a3ae", GitTreeState:"dirty", BuildDate:"2017-06-22T04:31:09Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}

$ ./build/bootstrap/bootstrap_linux_amd64 --wc.launcher=get.dev.weave.works --wc.hostname=frontend.dev.weave.works --token=xxxx
Preparing for Weave Cloud setup
Checking kubectl & kubernetes versions
Connecting cluster to "SuperWombat" (id: winter-fire-60) on Weave Cloud
Installing Weave Cloud agents on minikube at https://192.168.99.103:8443
Successfully installed.

$ kubectl -n weave get pods
NAME                                    READY     STATUS    RESTARTS   AGE
kube-state-metrics-963729613-7mnhn      1/1       Running   0          7m
prom-node-exporter-qt945                1/1       Running   0          7m
prometheus-334148176-14mmd              2/2       Running   0          7m
weave-agent-3883908326-t274l            1/1       Running   0          8m
weave-flux-agent-752199762-b94z2        1/1       Running   0          7m
weave-flux-memcached-2593342385-5hh10   1/1       Running   0          7m
weave-scope-agent-mq20r                 1/1       Running   0          7m

And things are showing up in WC as expected.

dlespiau commented 6 years ago

Thanks for your understanding!