search

weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

circleci: Wait for DNS to be ready #201

Closed lilic closed 6 years ago

lilic commented 6 years ago

Due to occasional errors with pre-flight DNS check in the launcher, we want to add this sleep for now, as a way of giving k8s time to setup DNS in the cluster.

https://github.com/weaveworks/launcher/issues/199

Still think we should come up with a better solution then sleeping, so maybe we shouldn't close the issue for now. Guess doing a preflight check so we avoid failing a preflight check is a bit meta? :)

dlespiau commented 6 years ago

Agreed, we could do a much better job than a sleep, so we can leave the issue open. Turns out testing with minikube on CI has a few gotchas!

dlespiau commented 6 years ago

We already have a wait_for_minikube, the 30s could be factored out there.

lilic commented 6 years ago

@dlespiau PTALA, thanks!

dlespiau commented 6 years ago

:+1: