search

weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

Confirm the cluster to run against before running #262

Open guyfedwards opened 6 years ago

guyfedwards commented 6 years ago

Confirm that the user is running against the correct cluster by showing them the name and then prompting user confirmation before running the setup.

rade commented 6 years ago

What do you mean by 'name'?

We are already showing the cluster. It's the confirmation prompt that is missing.

The prompt ought to be optional (via a flag) in order to cater for headless installs.

I am pretty sure we've had discussions in the past about prompts in the launcher, possibly even for this specific case - worth scouring prior github issues/PRs.

bia commented 6 years ago

Could we also include info about the K8s version the person is running in this prompt?

cc @rndstr

rndstr commented 6 years ago

@bia sure, what's the reasoning behind it? my understanding is the prompt is designed to make sure no mistake happens. would the user change his decision depending on the k8s version he sees there?

@rade i think this is about the cluster name since kubectl could be set up to point to an unexpected cluster.

we could also allow the cluster to be changed with a prompt that allows selection from all the clusters (kubectl config get-clusters)

bia commented 6 years ago

sure, what's the reasoning behind it?

Just giving people a complete confirmation of what they are about to set up.