weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

Update manifests from v1beta1 -> v1 #299

Closed foot closed 5 years ago

foot commented 5 years ago

Fixes #298

foot commented 5 years ago

Edit: this was fixed by dropping back to mk 1.2.0 for now.

Test failure:

https://circleci.com/gh/weaveworks/launcher/43550?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

deployment.apps/service created
• Wait for launcher/service pod to become ready
• Wait for launcher/service to be fully reachable
• Install Weave Cloud on the minikube cluster
sh: 1: Syntax error: redirection unexpected

Which seems to be this line

curl -Ls $(minikube service service --url) | sh -s -- --token=${WEAVE_CLOUD_TOKEN} --assume-yes

Where curl is returning an HTML docs that looks like this?!

Screenshot 2019-09-19 at 17 06 20

So service is probably not ready yet?..

bboreham commented 5 years ago

Tests have now passed - one failed the time before so I added code to get logs, but then it didn't fail.