search

weaveworks / launcher

Weave Cloud Launcher
Apache License 2.0
10 stars 13 forks source link

agent: Use git version instead of major and minor #56

Closed aaron7 closed 6 years ago

aaron7 commented 6 years ago

Major and minor is blank on the latest minikube build: https://github.com/kubernetes/minikube/issues/2505

Kuberenetes itself is also planning to deprecate these fields.

Use the git version (vX.X.X) instead, which the launch generator supports.

rade commented 6 years ago

Kuberenetes itself is also planning to deprecate these fields.

Really? That would break LG! Please file an issue there with details.

aaron7 commented 6 years ago

Really? That would break LG! Please file an issue there with details.

yep - https://github.com/kubernetes/minikube/pull/2511#issuecomment-362929821

https://github.com/weaveworks/launch-generator/issues/240