validate artifact names are unique during pctl add

weaveworks / pctl

CLI for interacting with profiles

Other

7 stars 6 forks source link

validate artifact names are unique during pctl add #339

Closed aclevername closed 3 years ago

aclevername commented 3 years ago

Description

Closes #336

Checklist

[ ] Added tests that cover your change
[ ] Added/modified documentation as required (such as the README.md)
[ ] Made sure the title of the PR is a good description that can go into the release notes
[ ] Added a kind label to the PR (e.g. kind/feature)

Skarlso commented 3 years ago

@aclevername I fixed this here! But I HAVE NO IDEA WHY. :D I added a go mod download and a go mod tidy before running the linter. I'm guessing it didn't download something. You had passing runs before you made a main merge.

Maybe compare what changed? And if nothing comes to mind, I suggest that we just add a go mod download and go mod tidy in the workflow before running make test. What do you think?

Skarlso commented 3 years ago

O woot \o/ seems to be working now. :D