Check if `make test` modifies go mod files

weaveworks / pipeline-controller

This repository contains the Pipeline CRD and associated controller for Weave GitOps Enterprise.

1 stars 4 forks source link

Check if `make test` modifies go mod files #205

Closed squaremo closed 11 months ago

squaremo commented 11 months ago

It's easy to accidentally leave out changes to go mod files (go.mod, go.sum, go.work.sum) when preparing PRs, especially if you rebase. Usually, any go operation would catch it, because the default is -mod readonly; but, workspace files seem exempt from this, and go vet doesn't appear to honour it either.

Therefore: add a backstop in the GitHub Actions workflow, to stop incidental changes slipping through.

squaremo commented 11 months ago

Closing in favour of just removing the workspace files (#206).