weaveworks / pipeline-controller

This repository contains the Pipeline CRD and associated controller for Weave GitOps Enterprise.
1 stars 4 forks source link

Adds sample templates #76

Closed sympatheticmoose closed 1 year ago

sympatheticmoose commented 1 year ago

This PR adds 4 sample templates to enable pipeline creation through the Weave GitOps Enterprise GUI. These:

Need to validate how usable they are vs documented examples.

Missing resources that would need to be created:

Notes:

enekofb commented 1 year ago

Comments added a couple of common themes

enekofb commented 1 year ago

another comment would be how the update cycle would look in the context of early feedback from SAs

In the best case scenario they won't need to do changes but likely that they might need to do changes. Given that the templates are shipped within pipeline controller, how do we expect this journey would work?

a) SAs / Us to create new templates from the sample ones and to eventually retrofit the changes b) SAs to wait for new releases to

It make sense to decouple the availability of pipeline templates from the wge release cycle in particular in the early feedback / validation stage that we are.

sympatheticmoose commented 1 year ago

to split responsibilities on what the app developer should add vs platform admin

Could you expand on the specific concerns here? The params are there for the person associating the application with the pipeline; the rest of the template is what the administrator is setting as a standard/enforced.

the expectations out of the add pipeline, in particular when you want to have a pipeline with promotions

The way I've done this so far is to offer a set template where it is not handling promotions; are you suggesting something else?

Sorry, I'm not clear on these points? 🙂

sympatheticmoose commented 1 year ago

another comment would be how the update cycle would look in the context of early feedback from SAs

In the best case scenario they won't need to do changes but likely that they might need to do changes. Given that the templates are shipped within pipeline controller, how do we expect this journey would work?

a) SAs / Us to create new templates from the sample ones and to eventually retrofit the changes b) SAs to wait for new releases to

It make sense to decouple the availability of pipeline templates from the wge release cycle in particular in the early feedback / validation stage that we are.

These are purely default sample templates, the SAs/user could create new ones and install/manage themselves, these samples can be updated on a 2 week cadence based on current release process - which may not be reflected in a customer environment, but nonetheless, a very simple work around is possible.

The alternatives I considered were:

enekofb commented 1 year ago

closing ... splitting in single use case PRs by scenario and opening in enterprise repo