WGE v0.9.4 Sources pages with OCIRepository errors for leave clusters with old flux

weaveworks / sa-demos

This repository is dealing with the Weave GitOps demos and demo environments. Please use it to file and update issues that you are seeing. You can also put your demo guides and demo scripts here.

1 stars 0 forks source link

WGE v0.9.4 Sources pages with OCIRepository errors for leave clusters with old flux #44

Closed LutzLange closed 2 years ago

LutzLange commented 2 years ago

Old flux in leaf clusters that don't support OCIRepository will raise error messages on the Source page.

This can't be the intended way. A warning might be ok, but not as prominent. Also think about raising this as a flux update request / issue.

Screenshot from 2022-09-13 10-09-27

bigkevmcd commented 2 years ago

The very least we should do, is flatten the errors a bit...

no matches for kind "OCIRepository" in version "source.toolkit.fluxcd.io/v1beta2" clusters: ["default/eks-elk13", "default/lutz-lm6"]

But, this should also be optional as CAPI etc are.

foot commented 2 years ago

Yes, this a bit rough. It was featureflagged off, but the featureflag got dropped during some refactoring. :(.

Quick fix we could filter out no matches for kind .* in version .* from the errors.
Better fix treat that as an info in blue and collapsed or something as Lutz has suggested in the past for policy.
Should re-intro the featureflag too.

LutzLange commented 2 years ago

This is essentially multiple issues.

These errors are to prominent.
It looks broken, but it is not.

Display this as outdated flux version on Leaf Cluster.

LutzLange commented 2 years ago

The improvement removes the cluster names as well. So this is not actionable information any more. I do not have a way to find out which clusters the errors belong to.

https://github.com/weaveworks/sa-demos/issues/52

LutzLange commented 2 years ago

Updated flux on all leaf clusters was the workaround. Closed won't fix for now.