weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.87k stars 714 forks source link

Websocket tracing spans #3682

Closed bboreham closed 5 years ago

bboreham commented 5 years ago

Since the http call lasts forever, the spans for it don't appear. Instead, start a new root span every time round the loop (which is typically every 5 seconds).

For the multitenant case it's useful to have a tag with the userid.

fbarl commented 5 years ago

Thanks for the changes, feel free to merge now!