search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.87k stars 714 forks source link

performance(aws_collector): don't persist shortcut reports #3716

Closed bboreham closed 5 years ago

bboreham commented 5 years ago

Shortcut reports are sent to update the UI quickly, on events like a container starting.

We don't need to persist them in the time-travel data since the same information will be covered by a regular report a few seconds later.

bboreham commented 5 years ago

S3 charges per write (and read) as well as for monthly storage. Also DynamoDB writes require provisioning.

I believe shortcut reports are sent immediately to the UI.

rade commented 5 years ago

I believe shortcut reports are sent immediately to the UI.

Even when time-travelling?

bboreham commented 5 years ago

I was wondering whether this make the UI less fluid when time-travelling

Sorry I didn't read that last bit.

In time-travel mode, if you inch the time forward by one second you would be able to tell the difference. I'm not sure I would call that "fluid" since it's quite hard to achieve such fine control, and a moderately-sized report will take a couple of seconds to render. I don't think this is worth commenting.