Update Ruby version for the benefit of Netlify build

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes

https://www.weave.works/oss/scope/

Apache License 2.0

5.87k stars 714 forks source link

Closed bboreham closed 4 years ago

bboreham commented 4 years ago

Scope does not use Ruby, but we (apparently) need this file to make the Netlify website build go.

And Netlify builds have been failing recently saying the version had to be at least 2.5.2.

bboreham commented 4 years ago

It's still failing, possibly because a contentstack token is needed. I know nothing about how the website is set up.

fbarl commented 4 years ago

Missing Contentstack environment variable: CONTENTSTACK_STACK_TOKEN

Hmm, it's weird there's nothing about this on the internet :thinking:

The Ruby version bump still feels like a step forward though, as at passes through the step where it was failing before.

Maybe setting .nvmrc to something never as well, e.g. v12.9.1, would solve the problem - the currently cached one v6.17.1 is really old!

dholbach commented 4 years ago

I don't know much about this either, but the Website repo, scope and weave-net will all have to have the same ruby version AFAIR.

RichiePowell commented 4 years ago

I have gone ahead and added the missing Contentstack env variable to Netlify. Could we re-run this build test, please?